yew-macro: silence non-normalised element name warnings for SVG elements#3769
Merged
ranile merged 1 commit intoyewstack:masterfrom Dec 13, 2024
Merged
Conversation
its-the-shrimp
force-pushed
the
fix-normalised-element-name-warning
branch
from
420392b to
e14d9dc
Compare
its-the-shrimp
force-pushed
the
fix-normalised-element-name-warning
branch
from
e14d9dc to
d0b04a0
Compare
ranile
added a commit
to langyo/yew
that referenced
this pull request
Dec 13, 2024
ranile
added a commit
that referenced
this pull request
Dec 17, 2024
* Update CHANGELOG https://github.com/yewstack/yew/actions/runs/11314974928/job/31465588862 * Add items. * Write blog. * Archive the documents. * Add author. * Update SSR document. * Fix typo. * Add simplified Chinese translation. * Update package.json * Sync documents * Add traditional Chinese translation. * Sync documents * Add Japanese translation. * Sync documents * Fix typo by `fmt:write`. * Fix typo by `write-translations`. * Apply suggestions from code review * Fix typo. * #3769 in changelog --------- Co-authored-by: Elina <imelina@elina.website>
geoffjay
pushed a commit
to geoffjay/yew
that referenced
this pull request
Jan 25, 2025
geoffjay
pushed a commit
to geoffjay/yew
that referenced
this pull request
Jan 25, 2025
* Update CHANGELOG https://github.com/yewstack/yew/actions/runs/11314974928/job/31465588862 * Add items. * Write blog. * Archive the documents. * Add author. * Update SSR document. * Fix typo. * Add simplified Chinese translation. * Update package.json * Sync documents * Add traditional Chinese translation. * Sync documents * Add Japanese translation. * Sync documents * Fix typo by `fmt:write`. * Fix typo by `write-translations`. * Apply suggestions from code review * Fix typo. * yewstack#3769 in changelog --------- Co-authored-by: Elina <imelina@elina.website>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the edit in the macro test shows, SVG elements that are named in the camelCase convention don't trigger the warning for a non-nomalised form of their name
Modifications outside of yew-macro had to be done to please Clippy
Checklist